support custom TopCP images #1163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This reverts commit 86d536d.
…/ssl-hep/ServiceX into 1162-support-custom-topcp-images
…62-support-custom-topcp-images
for more information, see https://pre-commit.ci
…62-support-custom-topcp-images
…/ssl-hep/ServiceX into 1162-support-custom-topcp-images
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1163 +/- ##
===========================================
+ Coverage 85.83% 85.88% +0.04%
===========================================
Files 94 94
Lines 3191 3223 +32
Branches 359 368 +9
===========================================
+ Hits 2739 2768 +29
- Misses 378 380 +2
- Partials 74 75 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…62-support-custom-topcp-images
for more information, see https://pre-commit.ci
…/ssl-hep/ServiceX into 1162-support-custom-topcp-images
for more information, see https://pre-commit.ci
…/ssl-hep/ServiceX into 1162-support-custom-topcp-images
for more information, see https://pre-commit.ci
…/ssl-hep/ServiceX into 1162-support-custom-topcp-images
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend work for supporting custom TopCP images from whitelisted Docker registry repositories: ssl-hep/ServiceX_frontend#658
TODO: Merge https://github.com/ssl-hep/ServiceX/pull/555/files in before.